scaler_bench - benchmark for video scaling code.

scaler_bench is a simple benchmark that can be used to measure performance of our image scaling code. In this version it times performance of image scaling using Skia, and using Chromium's own scaler with and without filtering. 

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44950

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45067

[fbarchard, 2010-04-18 06:21:30]

LGTM
I've extended it to separate vertical and horizontal filter.

i7 perf (chrome, so only mmx)
Skia: 22.1ms/frame
No filtering: 4.156ms/frame
Bilinear Vertical: 6.344ms/frame
Bilinear Horizontal: 7.998ms/frame
Bilinear: 10.58ms/frame

[jamesr, 2010-04-19 21:53:52]

I think you broke checkdeps, could you fix it please?

[Sergey Ulanov, 2010-04-19 22:39:53]

Added DEPS file. Please review.

[scherkus (not reviewing), 2010-04-19 22:47:50]

mostly style nits

http://codereview.chromium.org/1518034/diff/19001/20003
File media/tools/scaler_bench/scaler_bench.cc (right):

http://codereview.chromium.org/1518034/diff/19001/20003#newcode16
media/tools/scaler_bench/scaler_bench.cc:16: #include
"skia/ext/platform_canvas.h"
should be in alphabetical order

http://codereview.chromium.org/1518034/diff/19001/20003#newcode21
media/tools/scaler_bench/scaler_bench.cc:21: using base::TimeDelta;
should be in alphabetical order

http://codereview.chromium.org/1518034/diff/19001/20003#newcode27
media/tools/scaler_bench/scaler_bench.cc:27: int dest_height = 1000;
aww globals :(

could you make these static/anon namespace?

http://codereview.chromium.org/1518034/diff/19001/20003#newcode39
media/tools/scaler_bench/scaler_bench.cc:39: SkBitmap *bitmap = new SkBitmap();
pointer goes with type, not variable

http://codereview.chromium.org/1518034/diff/19001/20003#newcode50
media/tools/scaler_bench/scaler_bench.cc:50: clock_t start = clock();
try to use TimeTicks::HighResNow() instead of clock()

http://codereview.chromium.org/1518034/diff/19001/20003#newcode109
media/tools/scaler_bench/scaler_bench.cc:109: clock_t start = clock();
ditto

[Sergey Ulanov, 2010-04-19 23:09:46]

Fixed all of these.

On 2010/04/19 22:47:50, scherkus wrote:
> mostly style nits
> 
> http://codereview.chromium.org/1518034/diff/19001/20003
> File media/tools/scaler_bench/scaler_bench.cc (right):
> 
> http://codereview.chromium.org/1518034/diff/19001/20003#newcode16
> media/tools/scaler_bench/scaler_bench.cc:16: #include
> "skia/ext/platform_canvas.h"
> should be in alphabetical order
> 
> http://codereview.chromium.org/1518034/diff/19001/20003#newcode21
> media/tools/scaler_bench/scaler_bench.cc:21: using base::TimeDelta;
> should be in alphabetical order
> 
> http://codereview.chromium.org/1518034/diff/19001/20003#newcode27
> media/tools/scaler_bench/scaler_bench.cc:27: int dest_height = 1000;
> aww globals :(
> 
> could you make these static/anon namespace?
> 
> http://codereview.chromium.org/1518034/diff/19001/20003#newcode39
> media/tools/scaler_bench/scaler_bench.cc:39: SkBitmap *bitmap = new
SkBitmap();
> pointer goes with type, not variable
> 
> http://codereview.chromium.org/1518034/diff/19001/20003#newcode50
> media/tools/scaler_bench/scaler_bench.cc:50: clock_t start = clock();
> try to use TimeTicks::HighResNow() instead of clock()
> 
> http://codereview.chromium.org/1518034/diff/19001/20003#newcode109
> media/tools/scaler_bench/scaler_bench.cc:109: clock_t start = clock();
> ditto

[fbarchard, 2010-04-19 23:25:13]

http://codereview.chromium.org/1518034/diff/24001/25003
File media/tools/scaler_bench/scaler_bench.cc (right):

http://codereview.chromium.org/1518034/diff/24001/25003#newcode15
media/tools/scaler_bench/scaler_bench.cc:15: #include "media/base/yuv_convert.h"
sort order - y comes after v

http://codereview.chromium.org/1518034/diff/24001/25003#newcode26
media/tools/scaler_bench/scaler_bench.cc:26: int source_width = 1280;
these should be constants. ie static const int kSourceWidth = 1280;

http://codereview.chromium.org/1518034/diff/24001/25003#newcode28
media/tools/scaler_bench/scaler_bench.cc:28: int dest_width = 1600;
I suggest 1366x768 for destination size.

[fbarchard, 2010-04-20 07:39:01]

LGTM
just nits - run lint on it?
gcl lint scaler_bench

http://codereview.chromium.org/1518034/diff/24001/25002
File media/tools/scaler_bench/DEPS (right):

http://codereview.chromium.org/1518034/diff/24001/25002#newcode2
media/tools/scaler_bench/DEPS:2: "+skia/ext",
interesting... haven't seen this needed before

[scherkus (not reviewing), 2010-04-20 19:00:36]

LGTM