Issue 1518027: Incorrect chroma on the right border fixed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1518027: Incorrect chroma on the right border fixed. (Closed)

Created:
10 years, 8 months ago by Sergey Ulanov

Modified:
9 years, 7 months ago

Reviewers:
fbarchard

CC:
scherkus (not reviewing), awong, Alpha Left Google, fbarchard

Visibility:
Public.

Description

Incorrect chroma on the right border fixed. BUG=19113 TEST=Right border has correct color Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44455

Patch Set 1 #

Patch Set 2 : fixed wrong chroma on the bottom #

Total comments: 3

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -13 lines)			Patch
	M	media/base/yuv_convert.cc	View	1	5 chunks	+12 lines, -13 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fbarchard

10 years, 8 months ago (2010-04-14 06:21:41 UTC) #2

LGTM

http://codereview.chromium.org/1518027/diff/3002/6001
File media/base/yuv_convert.cc (right):

http://codereview.chromium.org/1518027/diff/3002/6001#newcode243
media/base/yuv_convert.cc:243: int source_y = source_y_subpixel >>
kFractionBits;
source... ya thats a better name

http://codereview.chromium.org/1518027/diff/3002/6001#newcode273
media/base/yuv_convert.cc:273: (((source_y >> y_shift) + 1) < (height >>
y_shift))) {
is this the error you referred to?

http://codereview.chromium.org/1518027/diff/3002/6001#newcode282
media/base/yuv_convert.cc:282: ubuf[uv_width] = ubuf[uv_width - 1];
good catch!

Expand Messages | Collapse Messages