Updated wifi tests to work with an OpenWrt router.

Updated wifi tests to work with an OpenWrt router.

[Sam Leffler, 2010-04-02 21:35:22]

http://codereview.chromium.org/1517016/diff/1/2
File server/site_linux_router.py (right):

http://codereview.chromium.org/1517016/diff/1/2#newcode22
server/site_linux_router.py:22: "iw list | grep ^Wiphy | cut -d\  -f2 | head -n
1").stdout
I think it's better to do the parsing work on the host instead of the router. 
You can't be sure you'll have grep, cut, head, etc. available.

http://codereview.chromium.org/1517016/diff/1/2#newcode28
server/site_linux_router.py:28: "ip link show | grep :\ eth | cut -d: -f2 | head
-n 1").stdout
same as above

http://codereview.chromium.org/1517016/diff/1/2#newcode42
server/site_linux_router.py:42: "/usr/sbin/ip link set $i down; /usr/sbin/brctl
delbr $i; "
extract pathnames for apps so they can be parameterized

http://codereview.chromium.org/1517016/diff/1/2#newcode52
server/site_linux_router.py:52: "done")
might want to pull this cleanup work out into a separate method

http://codereview.chromium.org/1517016/diff/1/2#newcode89
server/site_linux_router.py:89: if self.apmode:
Might need hostapd in adhoc mode too but this is ok for now (maybe leave
comment?)

http://codereview.chromium.org/1517016/diff/1/2#newcode93
server/site_linux_router.py:93: hostapd_args.append("driver=nl80211")
need to parameterize driver type; e.g. for madwifi

http://codereview.chromium.org/1517016/diff/1/2#newcode110
server/site_linux_router.py:110: chan = 7 + (freq - 5025) / 5
sigh, this mapping is unreliable but i guess we need it for now; thought hostapd
handled this

http://codereview.chromium.org/1517016/diff/1/3
File server/site_wifitest.py (right):

http://codereview.chromium.org/1517016/diff/1/3#newcode99
server/site_wifitest.py:99: if re.search('Linux', router_uname):
I think you want to move the re.search work into the router classes (are there
static methods in python?).  I'd also like to find a way to amortize the cost of
the uname work (or similar) over multiple object instantiations (e.g. the set
suites create 30-50 instances and we know the uname won't change between
objects).

One other thing; add a way to force the type of router from the parameters.

[neb, 2010-04-06 22:25:24]

http://codereview.chromium.org/1517016/diff/1/2
File server/site_linux_router.py (right):

http://codereview.chromium.org/1517016/diff/1/2#newcode22
server/site_linux_router.py:22: "iw list | grep ^Wiphy | cut -d\  -f2 | head -n
1").stdout
On 2010/04/02 21:35:22, Sam Leffler wrote:
> I think it's better to do the parsing work on the host instead of the router. 
> You can't be sure you'll have grep, cut, head, etc. available.

Done.

http://codereview.chromium.org/1517016/diff/1/2#newcode28
server/site_linux_router.py:28: "ip link show | grep :\ eth | cut -d: -f2 | head
-n 1").stdout
On 2010/04/02 21:35:22, Sam Leffler wrote:
> same as above

Done.

http://codereview.chromium.org/1517016/diff/1/2#newcode42
server/site_linux_router.py:42: "/usr/sbin/ip link set $i down; /usr/sbin/brctl
delbr $i; "
On 2010/04/02 21:35:22, Sam Leffler wrote:
> extract pathnames for apps so they can be parameterized

Done.

http://codereview.chromium.org/1517016/diff/1/2#newcode52
server/site_linux_router.py:52: "done")
On 2010/04/02 21:35:22, Sam Leffler wrote:
> might want to pull this cleanup work out into a separate method

Like I mentioned, I think that we should not clean up bridges and wired
interfaces. It will make the setup a bit more flexible. Also faster to run.

http://codereview.chromium.org/1517016/diff/1/2#newcode93
server/site_linux_router.py:93: hostapd_args.append("driver=nl80211")
On 2010/04/02 21:35:22, Sam Leffler wrote:
> need to parameterize driver type; e.g. for madwifi

Done.

http://codereview.chromium.org/1517016/diff/1/2#newcode110
server/site_linux_router.py:110: chan = 7 + (freq - 5025) / 5
On 2010/04/02 21:35:22, Sam Leffler wrote:
> sigh, this mapping is unreliable but i guess we need it for now; thought
hostapd
> handled this

I took a glance at it's parameter parsing code and there was no conversion
there. I also tried it and it didn't work.

[Sam Leffler, 2010-04-06 22:28:35]

LGTM