Issue 1515005: Revert svn r4269 and r4298.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1515005: Revert svn r4269 and r4298. (Closed)

Created:
10 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Rico

CC:
v8-dev

Visibility:
Public.

Revert svn r4269 and r4298. The C++ implementation of String.prototype.replace triggers an assert in debug builds. See http://code.google.com/p/v8/issues/detail?id=667 Committed: http://code.google.com/p/v8/source/detail?r=4315

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -884 lines)			Patch
M	src/bootstrapper.cc	View	1 chunk	+1 line, -61 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/regexp.js	View	6 chunks	+31 lines, -40 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	11 chunks	+41 lines, -645 lines	0 comments	Download
M	src/string.js	View	2 chunks	+76 lines, -73 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/mirror-regexp.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/regexp.js	View	1 chunk	+0 lines, -48 lines	0 comments	Download

Total messages: 3 (0 generated)

LGTM