Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: test/cctest/test-profile-generator.cc

Issue 1514006: C++ profiles processor: put under #ifdef and fix issues. (Closed)
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/cpu-profiler-inl.h ('K') | « test/cctest/test-cpu-profiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-profile-generator.cc
diff --git a/test/cctest/test-profile-generator.cc b/test/cctest/test-profile-generator.cc
index b63dd1267871c4a955b9670f324332466150e459..808d3bec22f6daba090297baa984df728abcfa7f 100644
--- a/test/cctest/test-profile-generator.cc
+++ b/test/cctest/test-profile-generator.cc
@@ -2,6 +2,8 @@
//
// Tests of profiles generator and utilities.
+#ifdef ENABLE_CPP_PROFILES_PROCESSOR
+
#include "v8.h"
#include "profile-generator-inl.h"
#include "cctest.h"
@@ -10,6 +12,7 @@ namespace i = v8::internal;
using i::CodeEntry;
using i::CodeMap;
+using i::CpuProfile;
using i::CpuProfilesCollection;
using i::ProfileNode;
using i::ProfileTree;
@@ -45,7 +48,7 @@ namespace {
class ProfileTreeTestHelper {
public:
- explicit ProfileTreeTestHelper(ProfileTree* tree)
+ explicit ProfileTreeTestHelper(const ProfileTree* tree)
: tree_(tree) { }
ProfileNode* Walk(CodeEntry* entry1,
@@ -65,7 +68,7 @@ class ProfileTreeTestHelper {
}
private:
- ProfileTree* tree_;
+ const ProfileTree* tree_;
};
} // namespace
@@ -366,7 +369,7 @@ TEST(CodeMapMoveAndDeleteCode) {
TEST(RecordTickSample) {
CpuProfilesCollection profiles;
- profiles.AddProfile(0);
+ profiles.StartProfiling("", 1);
ProfileGenerator generator(&profiles);
CodeEntry* entry1 = generator.NewCodeEntry(i::Logger::FUNCTION_TAG, "aaa");
CodeEntry* entry2 = generator.NewCodeEntry(i::Logger::FUNCTION_TAG, "bbb");
@@ -375,11 +378,6 @@ TEST(RecordTickSample) {
generator.code_map()->AddCode(ToAddress(0x1700), entry2, 0x100);
generator.code_map()->AddCode(ToAddress(0x1900), entry3, 0x50);
- ProfileTreeTestHelper top_down_test_helper(profiles.profile()->top_down());
- CHECK_EQ(NULL, top_down_test_helper.Walk(entry1));
- CHECK_EQ(NULL, top_down_test_helper.Walk(entry2));
- CHECK_EQ(NULL, top_down_test_helper.Walk(entry3));
-
// We are building the following calls tree:
// -> aaa - sample1
// aaa -> bbb -> ccc - sample2
@@ -406,6 +404,11 @@ TEST(RecordTickSample) {
sample3.frames_count = 2;
generator.RecordTickSample(sample3);
+ CpuProfile* profile = profiles.StopProfiling("");
+ CHECK_NE(NULL, profile);
+ ProfileTreeTestHelper top_down_test_helper(profile->top_down());
+ CHECK_EQ(NULL, top_down_test_helper.Walk(entry2));
+ CHECK_EQ(NULL, top_down_test_helper.Walk(entry3));
ProfileNode* node1 = top_down_test_helper.Walk(entry1);
CHECK_NE(NULL, node1);
CHECK_EQ(entry1, node1->entry());
@@ -419,3 +422,5 @@ TEST(RecordTickSample) {
CHECK_NE(NULL, node4);
CHECK_EQ(entry1, node4->entry());
}
+
+#endif // ENABLE_CPP_PROFILES_PROCESSOR
« src/cpu-profiler-inl.h ('K') | « test/cctest/test-cpu-profiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698