Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1514006: C++ profiles processor: put under #ifdef and fix issues. (Closed)

Created:
10 years, 8 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev, Søren Thygesen Gjesse
Visibility:
Public.

Description

C++ profiles processor: put under #ifdef and fix issues. Committed: http://code.google.com/p/v8/source/detail?r=4317

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -102 lines) Patch
M SConstruct View 2 chunks +8 lines, -0 lines 2 comments Download
M src/circular-queue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cpu-profiler.h View 4 chunks +8 lines, -12 lines 0 comments Download
M src/cpu-profiler.cc View 3 chunks +3 lines, -1 line 0 comments Download
M src/cpu-profiler-inl.h View 1 chunk +3 lines, -1 line 2 comments Download
M src/profile-generator.h View 12 chunks +47 lines, -13 lines 0 comments Download
M src/profile-generator.cc View 11 chunks +120 lines, -30 lines 0 comments Download
M src/profile-generator-inl.h View 2 chunks +9 lines, -0 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 5 chunks +45 lines, -37 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 8 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mnaganov (inactive)
Kevin, this is the first patch. Sorry, it might look out of context for you. ...
10 years, 8 months ago (2010-03-30 07:18:44 UTC) #1
Kevin Millikin (Chromium)
LSTM (Look sane to me). You might want to consider wrapping the #includes also inside ...
10 years, 8 months ago (2010-03-30 11:26:29 UTC) #2
mnaganov (inactive)
10 years, 8 months ago (2010-03-30 11:35:24 UTC) #3
Thanks!

http://codereview.chromium.org/1514006/diff/1/2
File SConstruct (right):

http://codereview.chromium.org/1514006/diff/1/2#newcode1
SConstruct:1: # Copyright 2008 the V8 project authors. All rights reserved.
On 2010/03/30 11:26:29, Kevin Millikin wrote:
> 2010.

Done.

http://codereview.chromium.org/1514006/diff/1/4
File src/cpu-profiler-inl.h (right):

http://codereview.chromium.org/1514006/diff/1/4#newcode39
src/cpu-profiler-inl.h:39: #ifdef ENABLE_CPP_PROFILES_PROCESSOR
On 2010/03/30 11:26:29, Kevin Millikin wrote:
> You could wrap the entire contents of the file except the license comment.

Good idea! Fixed.

Powered by Google App Engine
This is Rietveld 408576698