Add the linux_use_debugallocation flag....

Add the linux_use_debugallocation flag.
Setting this flag to 1 shall force the use of debugallocation.cc instead of
tcmalloc.cc
The flag is off by default because it still needs testing.

BUG=30715
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44759

[willchan no longer on Chromium, 2010-04-15 17:24:51]

Excellent, thanks for working on this!
LGTM except some gyp nitpicks.

http://codereview.chromium.org/1513043/diff/3001/4002
File base/allocator/allocator.gyp (right):

http://codereview.chromium.org/1513043/diff/3001/4002#newcode339
base/allocator/allocator.gyp:339: [ 'linux_use_debugallocation==1', {
I think it's cleaner to use an 'else' rather than explicitly doing each
condition.  What you should do is something like:
[ 'linux_use_debugallocation==1', {
  ...
}, { # linux_use_debugallocation != 1
  ...
}],

http://codereview.chromium.org/1513043/diff/3001/4002#newcode341
base/allocator/allocator.gyp:341: '<(tcmalloc_dir)/src/tcmalloc.cc',
This stuff is magic to people who don't understand debugallocation.cc.  You
should add a comment explaining that debugallocation.cc will #include
tcmalloc.cc.

[Alexander Potapenko, 2010-04-16 07:19:56]

http://codereview.chromium.org/1513043/diff/3001/4002
File base/allocator/allocator.gyp (right):

http://codereview.chromium.org/1513043/diff/3001/4002#newcode339
base/allocator/allocator.gyp:339: [ 'linux_use_debugallocation==1', {
On 2010/04/15 17:24:51, willchan wrote:
> I think it's cleaner to use an 'else' rather than explicitly doing each
> condition.  What you should do is something like:
> [ 'linux_use_debugallocation==1', {
>   ...
> }, { # linux_use_debugallocation != 1
>   ...
> }],

Done.

http://codereview.chromium.org/1513043/diff/3001/4002#newcode341
base/allocator/allocator.gyp:341: '<(tcmalloc_dir)/src/tcmalloc.cc',
On 2010/04/15 17:24:51, willchan wrote:
> This stuff is magic to people who don't understand debugallocation.cc.  You
> should add a comment explaining that debugallocation.cc will #include
> tcmalloc.cc.

Done.