Issue 1513017: Delete bookmarks with backspace on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1513017: Delete bookmarks with backspace on mac (Closed)

Created:
10 years, 8 months ago by feldstein

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Visibility:
Public.

Description

Delete bookmarks with backspace on mac Safari deletes bookmarks using the backspace key, so we should too. BUG=39211 TEST=Highlight a bookmark and press the backspace key, the delete key, or meta+backspace. All should delete the bookmark. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43671

Patch Set 1 #

Patch Set 2 : Fix long line #

Total comments: 2

Patch Set 3 : Fix formatting to match following line #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/resources/bookmark_manager/main.html	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

LGTM with style nit fixed http://codereview.chromium.org/1513017/diff/2001/3001 File chrome/browser/resources/bookmark_manager/main.html (right): http://codereview.chromium.org/1513017/diff/2001/3001#newcode1549 chrome/browser/resources/bookmark_manager/main.html:1549: + (cr.isMac ? ' ...

10 years, 8 months ago (2010-04-05 23:00:06 UTC) #2

feldstein

10 years, 8 months ago (2010-04-05 23:03:00 UTC) #3

http://codereview.chromium.org/1513017/diff/2001/3001
File chrome/browser/resources/bookmark_manager/main.html (right):

http://codereview.chromium.org/1513017/diff/2001/3001#newcode1549
chrome/browser/resources/bookmark_manager/main.html:1549: + (cr.isMac ? ' U+0008
U+0008-meta' : '');
On 2010/04/05 23:00:06, arv wrote:
> binops before newlines in JS
> 
> The reason is that semi colon is optional and even though we require it in our
> style guide it makes it clearer that the statement is not complete.

Done, fixed to match line break style of next line.

Expand Messages | Collapse Messages