Initial work on Linux tab to search.

Initial work on Linux tab to search.

Still are a bunch of more complicated behavior that doesn't work, like hitting
backspace to remove the keyword.  The keyword hint and keyword display more or
less work, although things have gotten pretty complicated.

BUG=10965
TEST=Tab to search with a keyword.

[Dean McNamee, 2009-07-02 14:30:58]

The Windows logic for this is kinda complicated, they have a pretty big views
hierarchy with lots of custom views and layout for each component.  They also
rely a lot on custom key handling which doesn't work very well on GTK.

Oh well...

[Dan Erat, 2009-07-02 20:37:48]

LGTM

http://codereview.chromium.org/151209/diff/1004/1006
File chrome/browser/gtk/location_bar_view_gtk.cc (right):

http://codereview.chromium.org/151209/diff/1004/1006#newcode148
Line 148: 4, 4, 0, 0);
use constants from the top of the file instead of hardcoding these?  (we already
have ones like kEvTextPaddingRight)

http://codereview.chromium.org/151209/diff/1004/1006#newcode184
Line 184: // doesn't work because someone is probably call show_all on our
parent box.
s/call/calling/

http://codereview.chromium.org/151209/diff/1004/1006#newcode265
Line 265: //bool show_search_hint =
location_entry_->model()->show_search_hint();
delete this commented line, or add a comment describing what it's going to be
used for?

[Dean McNamee, 2009-07-06 15:10:19]

Ok, I'll address Dan's comments.

Evan?

On 2009/07/02 20:37:48, Dan Erat wrote:
> LGTM
> 
> http://codereview.chromium.org/151209/diff/1004/1006
> File chrome/browser/gtk/location_bar_view_gtk.cc (right):
> 
> http://codereview.chromium.org/151209/diff/1004/1006#newcode148
> Line 148: 4, 4, 0, 0);
> use constants from the top of the file instead of hardcoding these?  (we
already
> have ones like kEvTextPaddingRight)
> 
> http://codereview.chromium.org/151209/diff/1004/1006#newcode184
> Line 184: // doesn't work because someone is probably call show_all on our
> parent box.
> s/call/calling/
> 
> http://codereview.chromium.org/151209/diff/1004/1006#newcode265
> Line 265: //bool show_search_hint =
> location_entry_->model()->show_search_hint();
> delete this commented line, or add a comment describing what it's going to be
> used for?

[Dean McNamee, 2009-07-07 12:54:31]

Ping ping Evan ping.

On 2009/07/06 15:10:19, Dean McNamee wrote:
> Ok, I'll address Dan's comments.
> 
> Evan?
> 
> On 2009/07/02 20:37:48, Dan Erat wrote:
> > LGTM
> > 
> > http://codereview.chromium.org/151209/diff/1004/1006
> > File chrome/browser/gtk/location_bar_view_gtk.cc (right):
> > 
> > http://codereview.chromium.org/151209/diff/1004/1006#newcode148
> > Line 148: 4, 4, 0, 0);
> > use constants from the top of the file instead of hardcoding these?  (we
> already
> > have ones like kEvTextPaddingRight)
> > 
> > http://codereview.chromium.org/151209/diff/1004/1006#newcode184
> > Line 184: // doesn't work because someone is probably call show_all on our
> > parent box.
> > s/call/calling/
> > 
> > http://codereview.chromium.org/151209/diff/1004/1006#newcode265
> > Line 265: //bool show_search_hint =
> > location_entry_->model()->show_search_hint();
> > delete this commented line, or add a comment describing what it's going to
be
> > used for?

[Evan Martin, 2009-07-07 14:45:12]

LGTM