Issue 151207: X64: Fix floating point and integer instructions in assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151207: X64: Fix floating point and integer instructions in assembler. (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Fix floating point and integer instructions in assembler. Committed: http://code.google.com/p/v8/source/detail?r=2346

Patch Set 3 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	src/x64/assembler-x64.cc	View	1 2	12 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

http://codereview.chromium.org/151207/diff/1/3 File src/heap.cc (right): http://codereview.chromium.org/151207/diff/1/3#newcode89 Line 89: int Heap::initial_semispace_size_ = 4*MB; Please don't commit this!

11 years, 5 months ago (2009-07-02 14:17:30 UTC) #2

Lasse Reichstein

LGTM http://codereview.chromium.org/151207/diff/2001/3001 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/151207/diff/2001/3001#newcode1572 Line 1572: emit_optional_rex_32(adr); Ditto for the following opcodes?

11 years, 5 months ago (2009-07-03 08:59:14 UTC) #3

William Hesse

11 years, 5 months ago (2009-07-03 09:16:22 UTC) #4

http://codereview.chromium.org/151207/diff/2001/3001
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/151207/diff/2001/3001#newcode1572
Line 1572: emit_optional_rex_32(adr);
On 2009/07/03 08:59:14, Lasse Reichstein wrote:
> Ditto for the following opcodes?

Done.

Expand Messages | Collapse Messages

Issue 151207: X64: Fix floating point and integer instructions in assembler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages