Issue 1512032: WiFi test cleanups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1512032: WiFi test cleanups (Closed)

Created:
10 years, 8 months ago by Sam Leffler

Modified:
9 years, 7 months ago

Reviewers:
neb

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Visibility:
Public.

Description

WiFi test cleanups - move config file handling into WiFiTest class - move router autodetect to router classes - auto-detect BSD router wireless and wired nics

Patch Set 1 #

Total comments: 4

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -62 lines)			Patch
M	client/config/wifi_testbed_config	View	1 chunk	+3 lines, -3 lines	2 comments	Download
M	server/site_bsd_router.py	View	3 chunks	+27 lines, -5 lines	0 comments	Download
M	server/site_linux_router.py	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	server/site_tests/network_WiFiMatFunc/control	View	2 chunks	+8 lines, -12 lines	0 comments	Download
M	server/site_tests/network_WiFiSecMat/control	View	2 chunks	+8 lines, -11 lines	0 comments	Download
M	server/site_wifitest.py	View	9 chunks	+71 lines, -31 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

neb

Looks fine to me. I have a few silly things: http://codereview.chromium.org/1512032/diff/1/2 File client/config/wifi_testbed_config (right): http://codereview.chromium.org/1512032/diff/1/2#newcode19 ...

10 years, 8 months ago (2010-04-10 00:04:24 UTC) #2

Sam Leffler

10 years, 8 months ago (2010-04-12 15:52:55 UTC) #3

committing

http://codereview.chromium.org/1512032/diff/1/2
File client/config/wifi_testbed_config (right):

http://codereview.chromium.org/1512032/diff/1/2#newcode19
client/config/wifi_testbed_config:19: "addr"      : "172.22.71.64",
On 2010/04/10 00:04:24, neb wrote:
> Address change shouldn't be a part of the commit.

Done.

http://codereview.chromium.org/1512032/diff/1/7
File server/site_wifitest.py (right):

http://codereview.chromium.org/1512032/diff/1/7#newcode72
server/site_wifitest.py:72: # NB: truncate SSID to 32 characters
Nota Bene

Expand Messages | Collapse Messages