Issue 1512028: Landing http://codereview.chromium.org/1594017 for Ryan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1512028: Landing http://codereview.chromium.org/1594017 for Ryan. (Closed)

Created:
10 years, 8 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
ry, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Landing http://codereview.chromium.org/1594017 for Ryan. TBR=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=4367

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -0 lines)			Patch
M	include/v8.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

I also fixed minor stylistic issues with spaces (around + and after ,)

10 years, 8 months ago (2010-04-08 18:23:48 UTC) #1

On 2010/04/08 18:23:48, antonm wrote: > I also fixed minor stylistic issues with spaces (around ...

10 years, 8 months ago (2010-04-08 18:42:34 UTC) #2

Mads Ager (chromium)

10 years, 8 months ago (2010-04-09 08:09:47 UTC) #3

I'm don't really like exposing flattening in the API. It is an implementation
detail that we are using cons strings for string concatenation. Which operation
is the problem here. It seems that we need better heuristics internally in V8 to
handle this instead of spilling implementation details out through the API?

Expand Messages | Collapse Messages