Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1512022: Add NormalizeLanguageCode() to normalize language codes. (Closed)

Created:
10 years, 8 months ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
Yusuke Sato, James Su
CC:
chromium-reviews, mazda
Visibility:
Public.

Description

Add NormalizeLanguageCode() to normalize language codes. The normalization is needed to avoid duplicates in the language table in the language config diloag, as well as the combobox in the "add language" dialog, when engines return "jpn" and "ja" as language codes. Along the way, fixed typos in function names. TEST=added unit tests, and manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43705

Patch Set 1 #

Total comments: 2

Patch Set 2 : add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -9 lines) Patch
M chrome/browser/chromeos/options/language_config_view.h View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/language_config_view.cc View 9 chunks +28 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/options/language_config_view_test.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
10 years, 8 months ago (2010-04-06 07:11:38 UTC) #1
Yusuke Sato
lgtm http://codereview.chromium.org/1512022/diff/1/4 File chrome/browser/chromeos/options/language_config_view_test.cc (right): http://codereview.chromium.org/1512022/diff/1/4#newcode18 chrome/browser/chromeos/options/language_config_view_test.cc:18: TEST(LanguageConfigViewTest, NormalizeLanguageCode) { Can you add a todo ...
10 years, 8 months ago (2010-04-06 09:43:17 UTC) #2
satorux1
http://codereview.chromium.org/1512022/diff/1/4 File chrome/browser/chromeos/options/language_config_view_test.cc (right): http://codereview.chromium.org/1512022/diff/1/4#newcode18 chrome/browser/chromeos/options/language_config_view_test.cc:18: TEST(LanguageConfigViewTest, NormalizeLanguageCode) { On 2010/04/06 09:43:17, Yusuke Sato wrote: ...
10 years, 8 months ago (2010-04-06 11:09:38 UTC) #3
James Su
10 years, 8 months ago (2010-04-06 12:53:55 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698