Improve JsonDoubleQuoteT to do script escapes

base/json/string_escape.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/string_escape.h"
 
 #include <string>
 
 #include "base/string_util.h"
 
@@ skipping 40 matching lines @@
 template <class STR>
 void JsonDoubleQuoteT(const STR& str,
                       bool put_in_quotes,
                       std::string* dst) {
   if (put_in_quotes)
     dst->push_back('"');
 
   for (typename STR::const_iterator it = str.begin(); it != str.end(); ++it) {
     typename ToUnsigned<typename STR::value_type>::Unsigned c = *it;
     if (!JsonSingleEscapeChar(c, dst)) {
-      if (c < 32 || c > 126) {
-        // Technically, we could also pass through c > 126 as UTF8, but this is
-        // also optional.  It would also be a pain to implement here.
+      if (c < 32 || c > 126 || c == 60 || c == 62) {

[eroman, 2010/04/06 01:43:12]

nit: can you '<' instead of 60, and '>' instead of 62 ?

+        // 1. Escaping <, > to prevent script execution.
+        // 2. Technically, we could also pass through c > 126 as UTF8, but this
+        //    is also optional.  It would also be a pain to implement here.
         unsigned int as_uint = static_cast<unsigned int>(c);
         StringAppendF(dst, "\\u%04X", as_uint);
       } else {
         unsigned char ascii = static_cast<unsigned char>(*it);
         dst->push_back(ascii);
       }
     }
   }
 
   if (put_in_quotes)
@@ skipping 20 matching lines @@
   JsonDoubleQuoteT(str, put_in_quotes, dst);
 }
 
 std::string GetDoubleQuotedJson(const string16& str) {
   std::string dst;
   JsonDoubleQuote(str, true, &dst);
   return dst;
 }
 
 }  // namespace base