chrome/common/notification_type.h - Issue 1512007: Disallow display of multiple experimental.extension.popup(...) windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/notification_type.h

Issue 1512007: Disallow display of multiple experimental.extension.popup(...) windows (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/

Patch Set: '' Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/notification_type.h

===================================================================

--- chrome/common/notification_type.h (revision 46029)

+++ chrome/common/notification_type.h (working copy)

@@ -795,7 +795,10 @@

EXTENSION_BACKGROUND_PAGE_READY,

// Sent when a pop-up extension view is ready, so that notification may

- // be sent to pending callbacks.

+ // be sent to pending callbacks. Note that this notification is sent

+ // after all onload callbacks have been invoked in the main frame.

+ // The details is the ExtensionHost* hosted within the popup, and the source

+ // is a Profile*.

EXTENSION_POPUP_VIEW_READY,

// Sent when a browser action's state has changed. The source is the

« no previous file with comments | « chrome/common/extensions/docs/history.html ('k') | chrome/common/render_messages_internal.h » ('j') | no next file with comments »