Issue 151195: Simplifying renderer focus management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151195: Simplifying renderer focus management (Closed)

Created:
11 years, 5 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
ojan

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

We used to store/restore the frame and node that were focused last when a age would lose/gain focus. This patches lets WebKit takes care of it by using the new FocusController::setFocused method. BUG=http://crbug.com/15777 TEST=Open www.google.com, the focus should be on the text-field (focus ring + blinking caret). Activate another window. The page should not show the text-field with the focus. Switch tabs, make sure the focus is remembered correctly. Do the same tests in a page with frames. Run the layout tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19899

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -146 lines)			Patch
M	chrome/renderer/render_view.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	webkit/glue/webframe_impl.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/glue/webframeloaderclient_impl.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/glue/webview.h	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View		4 chunks	+0 lines, -11 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	1	6 chunks	+11 lines, -102 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages