Cleanup resources allocated by FFmpeg to avoid memory and threads leaks...

Cleanup resources allocated by FFmpeg to avoid memory and threads leaks
Calls avcodec_free and avcodec_thread_free appropriately.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20039

[Alpha Left Google, 2009-07-02 06:37:04]

let's try to hunt all leaks!

[scherkus (not reviewing), 2009-07-02 23:32:41]

do you want me to review this now, or are you still figuring it out?

[Alpha Left Google, 2009-07-03 00:29:53]

it's good for review now! :)

[scherkus (not reviewing), 2009-07-03 01:26:33]

few nits

http://codereview.chromium.org/151192/diff/3011/3015
File media/filters/ffmpeg_demuxer.cc (right):

http://codereview.chromium.org/151192/diff/3011/3015#newcode225
Line 225: // stopped, so this is the only safe place to do the global clean up.
add a TODO about how decoders shouldn't open the codecs

http://codereview.chromium.org/151192/diff/3011/3015#newcode227
Line 227: if (format_context_.get()) {
nit: avoid nesting, so check for the opposite condition and return

http://codereview.chromium.org/151192/diff/3011/3015#newcode230
Line 230: DCHECK(streams < 4);
I don't think we can assume this, so maybe just use nb_streams in for loop
directly

http://codereview.chromium.org/151192/diff/3011/3015#newcode247
Line 247: av_close_input_file(format_context_.release());
again you can either write your own functor that does this for you, or just use
a raw pointer

a scoped_ptr is a little scary

http://codereview.chromium.org/151192/diff/3011/3016
File media/filters/ffmpeg_demuxer.h (right):

http://codereview.chromium.org/151192/diff/3011/3016#newcode164
Line 164: scoped_ptr<AVFormatContext> format_context_;
either this should be a raw pointer, or you should write your own functor (like
ScopedPtrAVFree) that calls av_close_input_file()

reason being is that FFmpeg allocates format_context_ for us, but is deallocated
inside av_close_input_file() -- therefore calling delete on it would be very bad
:)

[scherkus (not reviewing), 2009-07-06 19:46:22]

LGTM