Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 151191: Make global variable initialization consistent with Firefox and Safari... (Closed)

Created:
11 years, 5 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Make global variable initialization consistent with Firefox and Safari behavior. Only force the introduction of a variable directly on the global object if there is an explicit initial value in a variable declaration. BUG=http://crbug.com/12548 Committed: http://code.google.com/p/v8/source/detail?r=2326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M src/runtime.cc View 1 chunk +14 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M test/cctest/test-decls.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 5 months ago (2009-07-02 06:07:39 UTC) #1
Kasper Lund
11 years, 5 months ago (2009-07-02 06:12:11 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698