reenable RenderViewHostManager browertest, add DownloadsCompleteObserver

reenable RenderViewHostManager browertest, add DownloadsCompleteObserver to ui_test_utils.

R=aa

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19811

[Aaron Boodman, 2009-07-02 01:51:53]

lgtm

nice addition to ui test utils

http://codereview.chromium.org/151189/diff/1/3
File chrome/test/ui_test_utils.cc (right):

http://codereview.chromium.org/151189/diff/1/3#newcode102
Line 102: class DownloadsCompleteObserver : public DownloadManager::Observer,
Do not follow the bad example of DOMOperationObserver: add a comment to this
class. One thing it could include is usage example.

http://codereview.chromium.org/151189/diff/1/3#newcode134
Line 134: download_manager_->RemoveObserver(this);
Looks like this can be done up above, when we realize that wait_count_ ==
downloads_.size()? That might clarify what's going on a bit.

[rafaelw, 2009-07-02 03:47:10]

http://codereview.chromium.org/151189/diff/1/3
File chrome/test/ui_test_utils.cc (right):

http://codereview.chromium.org/151189/diff/1/3#newcode102
Line 102: class DownloadsCompleteObserver : public DownloadManager::Observer,
On 2009/07/02 01:51:53, Aaron Boodman wrote:
> Do not follow the bad example of DOMOperationObserver: add a comment to this
> class. One thing it could include is usage example.

Done.

http://codereview.chromium.org/151189/diff/1/3#newcode134
Line 134: download_manager_->RemoveObserver(this);
On 2009/07/02 01:51:53, Aaron Boodman wrote:
> Looks like this can be done up above, when we realize that wait_count_ ==
> downloads_.size()? That m

Not done. But clarified with comments.