Issue 151181: Add a few more unit tests for page actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151181: Add a few more unit tests for page actions (Closed)

Created:
11 years, 5 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
rafaelw

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, brettw, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a couple of more extension unit tests for page actions. One for the helper function that parses a page action from the manifest and another that tests the page action api. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19840

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -2 lines)			Patch
M	chrome/common/extensions/extension.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_unittest.cc	View	1	3 chunks	+89 lines, -2 lines	1 comment	Download
M	chrome/renderer/extensions/extension_api_client_unittest.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

Rafael, I picked you at random from the Extension team to review this. :)

11 years, 5 months ago (2009-07-01 23:28:36 UTC) #1

rafaelw

11 years, 5 months ago (2009-07-02 20:28:08 UTC) #2

LGTM

http://codereview.chromium.org/151181/diff/10/1003
File chrome/common/extensions/extension_unittest.cc (right):

http://codereview.chromium.org/151181/diff/10/1003#newcode277
Line 277: ASSERT_EQ(static_cast<size_t>(2), page_action->icon_paths().size());
2u works as well. It's what extensions_service_unittest does all over the place.
(rather than static_cast)

Expand Messages | Collapse Messages