Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4025)

Unified Diff: chrome/browser/views/tabs/tab_overview_message_listener.cc

Issue 151172: Adds user metrics for tab overview. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/tabs/tab_overview_drag_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/tabs/tab_overview_message_listener.cc
===================================================================
--- chrome/browser/views/tabs/tab_overview_message_listener.cc (revision 19761)
+++ chrome/browser/views/tabs/tab_overview_message_listener.cc (working copy)
@@ -7,6 +7,7 @@
#include "chrome/browser/browser.h"
#include "chrome/browser/browser_list.h"
#include "chrome/browser/gtk/browser_window_gtk.h"
+#include "chrome/browser/metrics/user_metrics.h"
#include "chrome/browser/views/new_browser_window_widget.h"
#include "chrome/browser/views/tabs/tab_overview_controller.h"
#include "chrome/common/x11_util.h"
@@ -82,8 +83,8 @@
if (!over_mini_window)
return;
- // Not over a mini-window, make sure the controller is showing the
- // contents of the browser the mouse is over.
+ // Over a mini-window, make sure the controller is showing the contents
+ // of the browser the mouse is over.
BrowserWindowGtk* browser_window =
BrowserWindowGtk::GetBrowserWindowForNativeWindow(
BrowserWindowGtk::GetBrowserWindowForXID(message.param(0)));
@@ -97,6 +98,9 @@
select_message.set_type(TabOverviewTypes::Message::WM_MOVE_FLOATING_TAB);
select_message.set_param(0, message.param(1));
TabOverviewTypes::instance()->SendMessage(select_message);
+
+ UserMetrics::RecordAction(L"TabOverview_DragOverMiniWindow",
+ browser_window->browser()->profile());
}
default:
« no previous file with comments | « chrome/browser/views/tabs/tab_overview_drag_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698