Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Side by Side Diff: chrome/browser/history/history.cc

Issue 151168: Moved typedef of RedirectList from HistoryService class to history namespace.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/history/history.h ('k') | chrome/browser/history/history_backend.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // The history system runs on a background thread so that potentially slow 5 // The history system runs on a background thread so that potentially slow
6 // database operations don't delay the browser. This backend processing is 6 // database operations don't delay the browser. This backend processing is
7 // represented by HistoryBackend. The HistoryService's job is to dispatch to 7 // represented by HistoryBackend. The HistoryService's job is to dispatch to
8 // that thread. 8 // that thread.
9 // 9 //
10 // Main thread History thread 10 // Main thread History thread
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 void HistoryService::SetOnBackendDestroyTask(Task* task) { 246 void HistoryService::SetOnBackendDestroyTask(Task* task) {
247 ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::SetOnBackendDestroyTask, 247 ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::SetOnBackendDestroyTask,
248 MessageLoop::current(), task); 248 MessageLoop::current(), task);
249 } 249 }
250 250
251 void HistoryService::AddPage(const GURL& url, 251 void HistoryService::AddPage(const GURL& url,
252 const void* id_scope, 252 const void* id_scope,
253 int32 page_id, 253 int32 page_id,
254 const GURL& referrer, 254 const GURL& referrer,
255 PageTransition::Type transition, 255 PageTransition::Type transition,
256 const RedirectList& redirects, 256 const history::RedirectList& redirects,
257 bool did_replace_entry) { 257 bool did_replace_entry) {
258 AddPage(url, Time::Now(), id_scope, page_id, referrer, transition, redirects, 258 AddPage(url, Time::Now(), id_scope, page_id, referrer, transition, redirects,
259 did_replace_entry); 259 did_replace_entry);
260 } 260 }
261 261
262 void HistoryService::AddPage(const GURL& url, 262 void HistoryService::AddPage(const GURL& url,
263 Time time, 263 Time time,
264 const void* id_scope, 264 const void* id_scope,
265 int32 page_id, 265 int32 page_id,
266 const GURL& referrer, 266 const GURL& referrer,
267 PageTransition::Type transition, 267 PageTransition::Type transition,
268 const RedirectList& redirects, 268 const history::RedirectList& redirects,
269 bool did_replace_entry) { 269 bool did_replace_entry) {
270 DCHECK(history_backend_) << "History service being called after cleanup"; 270 DCHECK(history_backend_) << "History service being called after cleanup";
271 271
272 // Filter out unwanted URLs. We don't add auto-subframe URLs. They are a 272 // Filter out unwanted URLs. We don't add auto-subframe URLs. They are a
273 // large part of history (think iframes for ads) and we never display them in 273 // large part of history (think iframes for ads) and we never display them in
274 // history UI. We will still add manual subframes, which are ones the user 274 // history UI. We will still add manual subframes, which are ones the user
275 // has clicked on to get. 275 // has clicked on to get.
276 if (!CanAddURL(url) || PageTransition::StripQualifier(transition) == 276 if (!CanAddURL(url) || PageTransition::StripQualifier(transition) ==
277 PageTransition::AUTO_SUBFRAME) 277 PageTransition::AUTO_SUBFRAME)
278 return; 278 return;
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after
677 NotificationService::current()->Notify(type, source, det); 677 NotificationService::current()->Notify(type, source, det);
678 } 678 }
679 679
680 void HistoryService::OnDBLoaded() { 680 void HistoryService::OnDBLoaded() {
681 LOG(INFO) << "History backend finished loading"; 681 LOG(INFO) << "History backend finished loading";
682 backend_loaded_ = true; 682 backend_loaded_ = true;
683 NotificationService::current()->Notify(NotificationType::HISTORY_LOADED, 683 NotificationService::current()->Notify(NotificationType::HISTORY_LOADED,
684 Source<Profile>(profile_), 684 Source<Profile>(profile_),
685 Details<HistoryService>(this)); 685 Details<HistoryService>(this));
686 } 686 }
OLDNEW
« no previous file with comments | « chrome/browser/history/history.h ('k') | chrome/browser/history/history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698