Issue 151164: Remove a bunch of low-level keychain helper tests that are now redundant with...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151164: Remove a bunch of low-level keychain helper tests that are now redundant with... (Closed)

Created:
11 years, 5 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove a bunch of low-level keychain helper tests that are now redundant with tests of the newer higher-level methods. Start collecting the helpers into a cohesive class that serves as a translation layer between keychain items and password forms. BUG=none TEST=Keychain passwords should still fill after a username is typed on the Mac (no change in behavior). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19773

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+246 lines, -421 lines)			Patch
M	chrome/browser/password_manager/password_store_mac.cc	View	1 2	11 chunks	+127 lines, -105 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac_internal.h	View	1 2	2 chunks	+38 lines, -47 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac_unittest.cc	View	1 2	11 chunks	+81 lines, -269 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages