Issue 151163: Mangle the names of the libjpeg functions so gtk/gdk doesn't try to use our l...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151163: Mangle the names of the libjpeg functions so gtk/gdk doesn't try to use our l... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin, dank

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Mangle the names of the libjpeg functions so gtk/gdk doesn't try to use our libjpeg. TEST=along with <http://codereview.chromium.org/151100>;, it's possible to preview jpeg images BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19873

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -0 lines)			Patch
M	third_party/libjpeg/README.chromium	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/libjpeg/jpeglib.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	third_party/libjpeg/jpeglibmangler.h	View	1 chunk	+113 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

dank

LGTM. (I'm assuming this doesn't prevent us using the system libjpeg.)

11 years, 5 months ago (2009-07-02 23:00:18 UTC) #3

Evan Stade

Update: Sanity check: $ nm liblibjpeg.a | grep " T " | grep -v chromium ...

11 years, 5 months ago (2009-07-02 23:02:01 UTC) #4

LGTM2