Issue 151161: Skip all compositing tests. We ain't got no accelerated compositing hardware ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151161: Skip all compositing tests. We ain't got no accelerated compositing hardware ... (Closed)

Created:
11 years, 5 months ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
jorlow

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Skip all compositing tests. We ain't got no accelerated compositing hardware for dat. Also, remove a test we are passing due to backing out of changes upstream. R=jorlow BUG=15113 BUG=10474 BUG=15710 BUG=15733 TEST=no layout test regressions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19768

Patch Set 1 #

Patch Set 2 : Added back stuff I accidentally zapped #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -22 lines)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View	1	5 chunks	+3 lines, -22 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jorlow

http://codereview.chromium.org/151161/diff/3/1003 File webkit/tools/layout_tests/test_expectations.txt (left): http://codereview.chromium.org/151161/diff/3/1003#oldcode2849 Line 2849: BUG15710 : LayoutTests/fast/css/getComputedStyle/computed-style-font-family.html = FAIL Why is this ...

11 years, 5 months ago (2009-07-01 18:45:12 UTC) #3

dglazkov

It's now passing for us. This a bad baseline checked in upstream, then reverted.

11 years, 5 months ago (2009-07-01 19:04:54 UTC) #4

jorlow

11 years, 5 months ago (2009-07-01 20:12:44 UTC) #5

LGTM

You probably should add a comment to the CL about that test.

Make sure you update the proper bugs as well.

Expand Messages | Collapse Messages