Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: chrome/browser/cocoa/browser_window_controller.mm

Issue 151135: Pop-up chrome.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/browser_window_controller.mm
===================================================================
--- chrome/browser/cocoa/browser_window_controller.mm (revision 19669)
+++ chrome/browser/cocoa/browser_window_controller.mm (working copy)
@@ -422,6 +422,11 @@
return NO;
}
+ // Can't drag a tab from a normal browser to a pop-up
+ if (browser_->type() != realSource->browser_->type()) {
+ return NO;
+ }
+
return YES;
}
@@ -684,6 +689,13 @@
return base::SysUTF16ToNSString(contents->GetTitle());
}
+// TYPE_POPUP is not normal (e.g. no tab strip)
+- (BOOL)isNormalWindow {
+ if (browser_->type() == Browser::TYPE_NORMAL)
+ return YES;
+ return NO;
+}
+
- (void)selectTabWithContents:(TabContents*)newContents
previousContents:(TabContents*)oldContents
atIndex:(NSInteger)index

Powered by Google App Engine
This is Rietveld 408576698