Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5121)

Unified Diff: chrome/common/render_messages_internal.h

Issue 151130: Wire GetWindowRect, GetRootWindowRect, and GetScreenInfo out to the UI thread. (Closed)
Patch Set: Darin's suggestions. Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/renderer/render_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/render_messages_internal.h
diff --git a/chrome/common/render_messages_internal.h b/chrome/common/render_messages_internal.h
index d6ff6535e8485113468f7591bd58faa92ee6165c..288b4598d5273cf7834a06ba80672f15494e66ea 100644
--- a/chrome/common/render_messages_internal.h
+++ b/chrome/common/render_messages_internal.h
@@ -755,6 +755,8 @@ IPC_BEGIN_MESSAGES(ViewHost)
IPC_MESSAGE_ROUTED0(ViewHostMsg_Blur)
// Returns the window location of the given window.
+ // TODO(shess): Provide a mapping from reply_msg->routing_id() to
+ // HWND so that we can eliminate the NativeViewId parameter.
IPC_SYNC_MESSAGE_ROUTED1_1(ViewHostMsg_GetWindowRect,
gfx::NativeViewId /* window */,
gfx::Rect /* Out: Window location */)
@@ -965,11 +967,11 @@ IPC_BEGIN_MESSAGES(ViewHost)
#endif // defined(OS_WIN)
// Returns WebScreenInfo corresponding to the view.
- // TODO(darin): Change this to be a routed message so we don't need to pass
- // the view id.
- IPC_SYNC_MESSAGE_CONTROL1_1(ViewHostMsg_GetScreenInfo,
- gfx::NativeViewId /* native view id */,
- WebKit::WebScreenInfo /* results */)
+ // TODO(shess): Provide a mapping from reply_msg->routing_id() to
+ // HWND so that we can eliminate the NativeViewId parameter.
+ IPC_SYNC_MESSAGE_ROUTED1_1(ViewHostMsg_GetScreenInfo,
+ gfx::NativeViewId /* view */,
+ WebKit::WebScreenInfo /* results */)
// Send the tooltip text for the current mouse position to the browser.
IPC_MESSAGE_ROUTED1(ViewHostMsg_SetTooltipText,
@@ -1249,6 +1251,8 @@ IPC_BEGIN_MESSAGES(ViewHost)
bool /* enabled */)
// Returns the window location of the window this widget is embeded.
+ // TODO(shess): Provide a mapping from reply_msg->routing_id() to
+ // HWND so that we can eliminate the NativeViewId parameter.
IPC_SYNC_MESSAGE_ROUTED1_1(ViewHostMsg_GetRootWindowRect,
gfx::NativeViewId /* window */,
gfx::Rect /* Out: Window location */)
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/renderer/render_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698