Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1786)

Issue 151113: Don't screw up /usr/bin/ld if you can't write to current dir as root.... (Closed)

Created:
11 years, 5 months ago by dank
Modified:
9 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Don't screw up /usr/bin/ld if you can't write to current dir as root. BUG=http://crbug.com/15700 TEST=make sure ld is not gold, make sure root can't write to your nfs home directory, copy this script there, run it, let it install gold, verify it aborts early without torching /usr/bin/ld Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19683

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
MM build/install-build-deps.sh View 3 chunks +23 lines, -11 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
dank
This should avert the damage. I'm not worried about making this work if root can't ...
11 years, 5 months ago (2009-06-30 20:57:34 UTC) #1
Paweł Hajdan Jr.
11 years, 5 months ago (2009-06-30 23:36:12 UTC) #2
After addressing this one issue, LGTM. Thanks for quick patch!

http://codereview.chromium.org/151113/diff/1/2
File build/install-build-deps.sh (right):

http://codereview.chromium.org/151113/diff/1/2#newcode69
Line 69: make install failed, not installing gold
Shouldn't that be echo?

Powered by Google App Engine
This is Rietveld 408576698