Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1742)

Unified Diff: plugin/build.scons

Issue 151106: Fix Mac installer build. We were not inserting the version number into the Ke... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: plugin/build.scons
===================================================================
--- plugin/build.scons (revision 19634)
+++ plugin/build.scons (working copy)
@@ -341,6 +341,10 @@
if make_installer:
+ env.ReplaceStrings(
+ "$ARTIFACTS_DIR/postflight.sh", '$MAC_INSTALLER_DIR/postflight.sh',
+ REPLACE_STRINGS = plugin_replace_strings
+ )
if int(ARGUMENTS.get('MAC_KILLSWITCH', 0)):
kill_command = 'rm "$ARTIFACTS_DIR/O3D.plugin/Contents/MacOS/o3d"'
else:
@@ -357,8 +361,6 @@
# and so work on debug or release builds without change.
Copy("$ARTIFACTS_DIR/$MAC_INSTALLER_PROJECT",
'$MAC_INSTALLER_DIR/$MAC_INSTALLER_PROJECT'),
- Copy("$ARTIFACTS_DIR/postflight.sh",
- '$MAC_INSTALLER_DIR/postflight.sh'),
'ditto "$MAC_INSTALLER_DIR/GoogleSoftwareUpdate.pkg" "$ARTIFACTS_DIR/GoogleSoftwareUpdate.pkg"',
# Make the installer.
kill_command,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698