GTK: Preview images in file chooser....

GTK: Preview images in file chooser.

BUG=http://crbug.com/15500
TEST=select an image in a file chooser


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19874

[Evan Martin, 2009-06-30 19:18:29]

Where do you put preview_ into the dialog?  I don't see how this works.

[Evan Stade, 2009-06-30 20:01:48]

> Where do you put preview_ into the dialog?  I don't see how this works.

uploaded wrong version; fixed. Also increased the preview size as it seemed kind
of small.

[Evan Stade, 2009-06-30 20:05:10]

ah, could you hold off on reviewing, I'm getting libjpeg crashes for some
reason.

[Evan Stade, 2009-06-30 20:06:11]

wrong library version :(

34	  /* Guard against version mismatches between library and caller. */
35	  cinfo->mem = NULL;		/* so jpeg_destroy knows mem mgr not called */
36	  if (version != JPEG_LIB_VERSION)
37	    ERREXIT2(cinfo, JERR_BAD_LIB_VERSION, JPEG_LIB_VERSION, version);

[Evan Martin, 2009-06-30 20:16:58]

LGTM

but the crash is sadness.  yet another 64-bit issue?  can you update 
http://code.google.com/p/chromium/wiki/Linux64BitIssues
?

We can perhaps do the same check ourselves that libjpeg does and not show the
preview in that case?

http://codereview.chromium.org/151100/diff/3/1005
File chrome/browser/gtk/dialogs_gtk.cc (right):

http://codereview.chromium.org/151100/diff/3/1005#newcode446
Line 446: gtk_file_chooser_set_preview_widget_active(chooser, pixbuf ? true :
false);
maybe TRUE and FALSE here

[Evan Stade, 2009-06-30 22:06:15]

I just posted to chromium-dev mailing list about this. Since it would be
annoying to try to figure out if the file is a jpeg I'll just sit on this patch
in the mean time.

> maybe TRUE and FALSE here

Done.