Issue 151077: X64: Add Math.random, fix UnarySubStub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151077: X64: Add Math.random, fix UnarySubStub (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Add Math.random, fix UnarySubStub Committed: http://code.google.com/p/v8/source/detail?r=2320

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -16 lines)			Patch
	M	src/x64/codegen-x64.cc	View	1	2 chunks	+27 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/151077/diff/1/2 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/151077/diff/1/2#newcode5518 Line 5518: // Also enter it if the value ...

11 years, 5 months ago (2009-07-01 10:59:44 UTC) #2

William Hesse

11 years, 5 months ago (2009-07-01 12:00:27 UTC) #3

http://codereview.chromium.org/151077/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/151077/diff/1/2#newcode5518
Line 5518: // Also enter it if the value of the smi is MIN_INT.
On 2009/07/01 10:59:44, Lasse Reichstein wrote:
> MIN_INT -> Smi::kMinValue

Done.

Expand Messages | Collapse Messages