Issue 151075: X64: Make lazy arguments objects work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151075: X64: Make lazy arguments objects work (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Make lazy arguments objects work Committed: http://code.google.com/p/v8/source/detail?r=2305

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -2 lines)			Patch
	M	src/x64/codegen-x64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/x64/codegen-x64.cc	View		3 chunks	+40 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. Do you use TakeValue on X64 yet? If so, you need to disable it ...

11 years, 5 months ago (2009-06-30 12:00:34 UTC) #2

William Hesse

11 years, 5 months ago (2009-06-30 12:14:39 UTC) #3

On 2009/06/30 12:00:34, Kasper Lund wrote:
> LGTM. Do you use TakeValue on X64 yet? If so, you need to disable it for
access
> to the arguments object. See:
> 
> http://codereview.chromium.org/150016

We don't use it yet.  Added this issue to the relevant TODO.

Expand Messages | Collapse Messages