Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 151060: add ignore_edge option in test list. (Closed)

Created:
11 years, 5 months ago by yux
Modified:
9 years, 7 months ago
Reviewers:
vangelis
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

add ignore_edge option in test list. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21026

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -39 lines) Patch
M tests/selenium/javascript_unit_test_list.txt View 1 2 3 chunks +9 lines, -3 lines 0 comments Download
M tests/selenium/main.py View 1 2 3 chunks +10 lines, -2 lines 0 comments Download
M tests/selenium/sample_list.txt View 1 2 2 chunks +40 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yux
11 years, 5 months ago (2009-06-30 00:04:48 UTC) #1
vangelis
Other than a few small comments, LGTM. This CL will have to wait though until ...
11 years, 5 months ago (2009-07-01 17:14:12 UTC) #2
vangelis
http://codereview.chromium.org/151060/diff/1002/1003 File tests/selenium/sample_list.txt (right): http://codereview.chromium.org/151060/diff/1002/1003#newcode67 Line 67: # Default is 1. 1 means ignore all ...
11 years, 5 months ago (2009-07-01 18:30:46 UTC) #3
yux
Fixed. I didn't change the threshold of mac coz I can't test in mac. the ...
11 years, 5 months ago (2009-07-02 23:56:52 UTC) #4
vangelis
11 years, 5 months ago (2009-07-09 02:46:52 UTC) #5
LGTM but let's wait until we have a mac binary before we check this in.

Powered by Google App Engine
This is Rietveld 408576698