add ignore_edge option in test list.

add ignore_edge option in test list.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21026

[vangelis, 2009-07-01 17:14:12]

Other than a few small comments, LGTM. 

This CL will have to wait though until we check in the pdiff changes for both
windows and mac.

http://codereview.chromium.org/151060/diff/1002/1005
File tests/selenium/javascript_unit_test_list.txt (right):

http://codereview.chromium.org/151060/diff/1002/1005#newcode52
Line 52: #   pdiff_edge_ignore_off : Turn off edge detection functin in pdiff.
typo: function

http://codereview.chromium.org/151060/diff/1002/1003
File tests/selenium/sample_list.txt (right):

http://codereview.chromium.org/151060/diff/1002/1003#newcode106
Line 106: medium  stencil_example                   screenshot(0)
screenshot(100) screenshot(7777) pdiff_threshold(200) pdiff_threshold_win(20800)
We should also check the individual platform thresholds and see if we can remove
them... Here we're setting the threshold for windows to 20800!  There's a few
more cases like this one below.

[vangelis, 2009-07-01 18:30:46]

http://codereview.chromium.org/151060/diff/1002/1003
File tests/selenium/sample_list.txt (right):

http://codereview.chromium.org/151060/diff/1002/1003#newcode67
Line 67: #       Default is 1. 1 means ignore all possible edges,
default value of 1 seems to be too aggressive.  It translates to an almost solid
block of pixels (save 1 pixel).  I think you want to be somewhere closer to 0.5

[yux, 2009-07-02 23:56:52]

Fixed. I didn't change the threshold of mac coz I can't test in mac.
the default edge threshold in pdiff is 5. threshold of pdiff is 200.
Thanks.
---
Xiao

On 2009/07/01 18:30:46, vangelis wrote:
> http://codereview.chromium.org/151060/diff/1002/1003
> File tests/selenium/sample_list.txt (right):
> 
> http://codereview.chromium.org/151060/diff/1002/1003#newcode67
> Line 67: #       Default is 1. 1 means ignore all possible edges,
> default value of 1 seems to be too aggressive.  It translates to an almost
solid
> block of pixels (save 1 pixel).  I think you want to be somewhere closer to
0.5

[vangelis, 2009-07-09 02:46:52]

LGTM but let's wait until we have a mac binary before we check this in.