Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 151018: Optimize %ClassOf() on IA-32 and use it instead of the... (Closed)

Created:
11 years, 5 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Optimize %ClassOf() on IA-32 and use it instead of the custom %HasXXXClass() calls. Committed: http://code.google.com/p/v8/source/detail?r=2293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -75 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M src/macros.py View 1 chunk +9 lines, -7 lines 0 comments Download
M src/mirror-delay.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/runtime.js View 2 chunks +2 lines, -4 lines 0 comments Download
M src/string.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8natives.js View 6 chunks +7 lines, -8 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
11 years, 5 months ago (2009-06-29 10:37:38 UTC) #1
Mads Ager (chromium)
11 years, 5 months ago (2009-06-29 10:44:04 UTC) #2
LGTM!

Nice cleanup as well.

Powered by Google App Engine
This is Rietveld 408576698