Issue 151009: Removes the ability to close or resize the hung renderer dialog on Mac....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151009: Removes the ability to close or resize the hung renderer dialog on Mac.... (Closed)

Created:
11 years, 5 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Removes the ability to close or minimize the hung renderer dialog on Mac. I'm leaving the window resizable for now, because I dislike non-resizable windows. This is easy enough to change later. BUG=None TEST=After bringing up the dialog, verify that the only way to dismiss it is by pressing either the wait button or the kill button. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20044

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -14 lines)			Patch
M	chrome/app/nibs/en.lproj/HungRendererDialog.xib	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/hung_renderer_controller.mm	View	1 2	2 chunks	+5 lines, -9 lines	0 comments	Download
M	chrome/browser/cocoa/hung_renderer_controller_unittest.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

11 years, 5 months ago (2009-07-07 16:26:38 UTC) #3

performClose: appears to no longer work, probably because I disabled the close
button.  I've changed all calls to use close: instead.

Expand Messages | Collapse Messages