X64: Fix tickprocessor on MacOS 64-bit.

X64: Implement tickprocessor sampling on 64-bit MacOS.  This issue on codereview has been accidentally reused from an earlier issue by a process mistake.

Committed: http://code.google.com/p/v8/source/detail?r=2640

[William Hesse, 2009-06-28 17:57:37]

A tiny change for you.

[Lasse Reichstein, 2009-06-28 18:17:32]

LGTM

[William Hesse, 2009-06-29 08:07:53]

Committed with change http://codereview.chromium.org/147205 in revision 2287

[William Hesse, 2009-08-02 18:12:56]

Ignore earlier comments on this issue - the issue number has somehow gotten
reused.

[Mikhail Naganov, 2009-08-03 04:56:11]

LGTM with a comment.

William, you sent it to a false Mikhail ;)

http://codereview.chromium.org/151004/diff/2001/3001
File src/platform-macos.cc (right):

http://codereview.chromium.org/151004/diff/2001/3001#newcode530
Line 530: sample.pc = state.__rip;
I think you also need to duplicate __DARWIN_UNIX03 switch here (or use a #define
which either adds a double underscore prefix or none.)

I remember that when you compile Chromium, !__DARWIN_UNIX03 branch is used.

[William Hesse, 2009-08-03 10:19:35]

I will test this new code tonight, and upload it to the changelist, but here is
a new version:

      // If profiling, we record the pc and sp of the profiled thread.
      if (sampler_->IsProfiling()
          && KERN_SUCCESS == thread_suspend(profiled_thread_)) {
#if V8_HOST_ARCH_X64
        thread_state_flavor_t flavor = x86_THREAD_STATE64;
        x86_thread_state64_t state;
        mach_msg_type_number_t count = x86_THREAD_STATE64_COUNT;
#define REGISTER_PREFIX_LETTER r
#elif V8_HOST_ARCH_IA32
        thread_state_flavor_t flavor = i386_THREAD_STATE;
        i386_thread_state_t state;
        mach_msg_type_number_t count = i386_THREAD_STATE_COUNT;
#define REGISTER_PREFIX_LETTER e
#else
#error Unsupported Mac OS X host architecture.
#endif  // V8_HOST_ARCH

#if __DARWIN_UNIX03
#define REGISTER_FIELD(name) (__ ## REGISTER_PREFIX_LETTER ## name)
#else
#define REGISTER_FIELD(name) (REGISTER_PREFIX_LETTER ## name)
#endif // __DARWIN_UNIX03

        if (thread_get_state(profiled_thread_,
                             flavor,
                             reinterpret_cast<natural_t*>(&state),
                             &count) == KERN_SUCCESS) {
          sample.pc = state.REGISTER_FIELD(ip);
          sample.sp = state.REGISTER_FIELD(sp);
          sample.fp = state.REGISTER_FIELD(bp);
          sampler_->SampleStack(&sample);
        }
        thread_resume(profiled_thread_);
      }

      // We always sample the VM state.
      sample.state = Logger::state();
      // Invoke tick handler with program counter and stack pointer.
      sampler_->Tick(&sample);

      // Wait until next sampling.
      usleep(sampler_->interval_ * 1000);
    }
  }
};

#undef REGISTER_PREFIX_LETTER
#undef REGISTER_FIELD

[William Hesse, 2009-08-04 14:47:52]

OK, this code should be right.  It works on X64, UNIX03.

[William Hesse, 2009-08-06 12:42:55]

Needs review.

[Mikhail Naganov, 2009-08-06 12:53:56]

Still LGTM