Issue 151002: Fixing focus problems with the combobox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151002: Fixing focus problems with the combobox (Closed)

Created:
11 years, 6 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fixing some combobox focus related issue. The combobox now needs to subclass the HWND to report focus changes to the FocusManager (as the FocusManager is not subclassing anymore). Made NativeControlWin always subclass for that reason, which led to getting rid of BUG=http://crbug.com/6900 TEST=Open the option dialog. Focus a comboxbox. Deactive then reactivate the dialog. The focus should be on the combobox. Click on the combobox to bring-up the list. Press ESC, this should close the list popup (not the dialog). Make sure all other components (buttons, checkboxes, radio-buttons, text-field) work as expected.

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -55 lines)			Patch
MM	views/controls/button/native_button_win.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
MM	views/controls/button/native_button_win.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
MM	views/controls/combobox/combobox.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
MM	views/controls/combobox/native_combobox_win.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
MM	views/controls/combobox/native_combobox_win.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
MM	views/controls/combobox/native_combobox_wrapper.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	views/controls/native_control.h	View		1 chunk	+2 lines, -11 lines	0 comments	Download
M	views/controls/native_control.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
MM	views/controls/native_control_win.h	View		2 chunks	+1 line, -9 lines	0 comments	Download
M	views/controls/native_control_win.cc	View	1	3 chunks	+6 lines, -19 lines	0 comments	Download
M	views/controls/tree/tree_view.h	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	views/focus/focus_manager_unittest.cc	View		5 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages