Add FilePath support to FileVersionInfo, fix Mac memory issues.

base/file_version_info.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_FILE_VERSION_INFO_H__
 #define BASE_FILE_VERSION_INFO_H__
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/file_path.h"
 #include "base/scoped_ptr.h"
 
 #ifdef OS_MACOSX
 #ifdef __OBJC__
 @class NSBundle;
 #else
 class NSBundle;
 #endif
 #endif
 
 // Provides a way to access the version information for a file.
 // This is the information you access when you select a file in the Windows
 // explorer, right-click select Properties, then click the Version tab.
 
 class FileVersionInfo {
  public:
   // Creates a FileVersionInfo for the specified path. Returns NULL if something
   // goes wrong (typically the file does not exit or cannot be opened). The
   // returned object should be deleted when you are done with it.
+  static FileVersionInfo* CreateFileVersionInfo(const FilePath& file_path);
+  // This version, taking a wstring, is deprecated and only kept around
+  // until we can fix all callers.
   static FileVersionInfo* CreateFileVersionInfo(const std::wstring& file_path);
 
   // Creates a FileVersionInfo for the current module. Returns NULL in case
   // of error. The returned object should be deleted when you are done with it.
   static FileVersionInfo* CreateFileVersionInfoForCurrentModule();
 
   ~FileVersionInfo();
 
   // Accessors to the different version properties.
   // Returns an empty string if the property is not found.
@@ skipping 30 matching lines @@
 #if defined(OS_WIN)
   FileVersionInfo(void* data, int language, int code_page);
 
   scoped_ptr_malloc<char> data_;
   int language_;
   int code_page_;
   // This is a pointer into the data_ if it exists. Otherwise NULL.
   VS_FIXEDFILEINFO* fixed_file_info_;
 #elif defined(OS_MACOSX)
   explicit FileVersionInfo(NSBundle *bundle);
-  explicit FileVersionInfo(const std::wstring& file_path);
   
   NSBundle *bundle_;
 #endif
 
   DISALLOW_EVIL_CONSTRUCTORS(FileVersionInfo);
 };
 
 #endif  // BASE_FILE_VERSION_INFO_H__