Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1508019: Update dump_symbols to match new file_id code. (Closed)

Created:
10 years, 8 months ago by agl
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update dump_symbols to match new file_id code. The way that breakpad calculates module ids has changed so we need to change our tools to match.

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M build/linux/dump_signature.py View 1 chunk +22 lines, -2 lines 8 comments Download

Messages

Total messages: 3 (0 generated)
agl
10 years, 8 months ago (2010-04-05 22:43:32 UTC) #1
Lei Zhang
LGTM with comments below. http://codereview.chromium.org/1508019/diff/1/2 File build/linux/dump_signature.py (right): http://codereview.chromium.org/1508019/diff/1/2#newcode3 build/linux/dump_signature.py:3: # Copyright (c) 2009 The ...
10 years, 8 months ago (2010-04-05 22:57:49 UTC) #2
agl
10 years, 8 months ago (2010-04-05 23:04:17 UTC) #3
Cheers. Landing.

http://codereview.chromium.org/1508019/diff/1/2
File build/linux/dump_signature.py (right):

http://codereview.chromium.org/1508019/diff/1/2#newcode3
build/linux/dump_signature.py:3: # Copyright (c) 2009 The Chromium Authors. All
rights reserved.
On 2010/04/05 22:57:50, Lei Zhang wrote:
> nit: 2010

Done.

http://codereview.chromium.org/1508019/diff/1/2#newcode11
build/linux/dump_signature.py:11: import struct
On 2010/04/05 22:57:50, Lei Zhang wrote:
> nit: struct then sys. (this is my fault)

Done.

http://codereview.chromium.org/1508019/diff/1/2#newcode25
build/linux/dump_signature.py:25: text_section = [x for x in
sections.split('\n') if '.text' in x]
On 2010/04/05 22:57:50, Lei Zhang wrote:
> text_section = [x for x in sections.splitlines() if '.text' in x]

Done.

http://codereview.chromium.org/1508019/diff/1/2#newcode30
build/linux/dump_signature.py:30: file_offset = int(text_section.split()[5], 16)
On 2010/04/05 22:57:50, Lei Zhang wrote:
> can you put this in a try: except ValueError block in this objdump outputs
> something unexpected?

Done.

Powered by Google App Engine
This is Rietveld 408576698