Issue 15077: Merge bleeding-edge change 985, RecordStatementPosition reform, into...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15077: Merge bleeding-edge change 985, RecordStatementPosition reform, into... (Closed)

Created:
12 years ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Merge bleeding-edge change 985, RecordStatementPosition reform, into experimental toiger compiler branch. Committed: http://code.google.com/p/v8/source/detail?r=1012

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -126 lines)			Patch
M	src/assembler-arm.h	View	1	2 chunks	+7 lines, -9 lines	0 comments	Download
M	src/assembler-arm.cc	View	1	2 chunks	+30 lines, -12 lines	0 comments	Download
M	src/assembler-ia32.h	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	src/assembler-ia32.cc	View	1	2 chunks	+20 lines, -13 lines	0 comments	Download
M	src/codegen.cc	View	1	3 chunks	+25 lines, -5 lines	0 comments	Download
M	src/codegen-arm.h	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	src/codegen-arm.cc	View	1	32 chunks	+33 lines, -35 lines	0 comments	Download
M	src/codegen-ia32.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/codegen-ia32.cc	View	1	33 chunks	+29 lines, -38 lines	0 comments	Download
M	src/parser.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

William Hesse

This change merged fine, except for a restructured for loop case in VisitLoopStatement. That should ...

12 years ago (2008-12-19 12:58:35 UTC) #1

Kevin Millikin (Chromium)

12 years ago (2008-12-19 14:05:40 UTC) #2

LGTM.  I only looked at the code generator changes that intersect with the work
on the branch.