Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1507002: Roll gtest r395:408 and gmock r278:282 to pick up ThreadLocal leak fix. (Closed)

Created:
10 years, 9 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel, Evan Martin
CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko
Visibility:
Public.

Description

Roll gtest r395:408 and gmock r278:282 to pick up ThreadLocal leak fix. BUG=39381 TEST=Valgrind stays green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42892

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -279 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M testing/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock/CHANGES View 1 chunk +7 lines, -4 lines 0 comments Download
M testing/gmock/CONTRIBUTORS View 1 chunk +1 line, -0 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-matchers.h View 3 chunks +18 lines, -3 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-matchers.h.pump View 2 chunks +15 lines, -2 lines 0 comments Download
M testing/gmock/include/gmock/gmock-matchers.h View 30 chunks +84 lines, -87 lines 0 comments Download
M testing/gmock/include/gmock/gmock-spec-builders.h View 5 chunks +6 lines, -6 lines 0 comments Download
M testing/gmock/test/gmock-generated-matchers_test.cc View 7 chunks +65 lines, -20 lines 0 comments Download
M testing/gmock/test/gmock-matchers_test.cc View 53 chunks +313 lines, -124 lines 0 comments Download
M testing/gmock/test/gmock_output_test_golden.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
10 years, 9 months ago (2010-03-27 01:38:07 UTC) #1
M-A Ruel
10 years, 9 months ago (2010-03-27 01:39:28 UTC) #2
Removing suppressions! It's great.

Happy rubberstamp lgtm.

Powered by Google App Engine
This is Rietveld 408576698