Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/renderer/renderer.scons

Issue 15051: Convert from using env['PLATFORM'] directly to using the more flexible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/plugin/plugin.scons ('k') | chrome/test/activex_test_control/activex_test_control.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/renderer.scons
===================================================================
--- chrome/renderer/renderer.scons (revision 7247)
+++ chrome/renderer/renderer.scons (working copy)
@@ -20,7 +20,7 @@
],
)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.Prepend(
CPPPATH = [
'$CHROME_DIR/tools/build/win',
@@ -53,7 +53,7 @@
]
# TODO(port): Port these to Linux
-if env['PLATFORM'] == 'posix':
+if env.Bit('linux'):
to_be_ported_files = [
'chrome_plugin_host.cc',
'debug_message_handler.cc',
@@ -72,7 +72,7 @@
input_files.remove(remove)
# TODO(port): Port these to Mac
-if env['PLATFORM'] == 'darwin':
+if env.Bit('mac'):
to_be_ported_files = [
'about_handler.cc',
'chrome_plugin_host.cc',
@@ -100,5 +100,5 @@
# TODO(port): Enable for Mac.
-if env['PLATFORM'] in ('posix', 'win32'):
+if not env.Bit('mac'):
env.ChromeStaticLibrary('renderer', input_files)
« no previous file with comments | « chrome/plugin/plugin.scons ('k') | chrome/test/activex_test_control/activex_test_control.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698