Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: chrome/common/common.scons

Issue 15051: Convert from using env['PLATFORM'] directly to using the more flexible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.scons ('k') | chrome/common/ipc_tests.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/common.scons
===================================================================
--- chrome/common/common.scons (revision 7247)
+++ chrome/common/common.scons (working copy)
@@ -32,7 +32,7 @@
],
)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.Prepend(
CPPPATH = [
'$CHROME_DIR/tools/build/win',
@@ -41,7 +41,7 @@
input_files = []
-if env['PLATFORM'] in ('posix', 'win32'):
+if not env.Bit('mac'):
# TODO(port): Port to Mac.
input_files.extend([
'animation.cc',
@@ -77,7 +77,7 @@
'visitedlink_common.cc',
])
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# TODO(port): Port these.
input_files.extend([
'child_process.cc',
@@ -111,24 +111,24 @@
'worker_thread_ticker.cc',
])
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# Windows specific files
input_files.extend([
'gfx/chrome_font_win.cc',
'ipc_channel_win.cc',
])
-elif env['PLATFORM'] == 'posix':
+elif env.Bit('linux'):
input_files.extend([
'gfx/chrome_canvas_skia.cc',
'gfx/chrome_font_skia.cc',
])
-if env['PLATFORM'] in ['posix', 'mac']:
+if env.Bit('posix'):
input_files.extend([
'ipc_channel_posix.cc',
])
-if env['PLATFORM'] in ('posix', 'win32'):
+if not env.Bit('mac'):
# TODO(port): This should be enabled for all platforms.
env.ChromeStaticLibrary('common', input_files)
« no previous file with comments | « chrome/chrome.scons ('k') | chrome/common/ipc_tests.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698