Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: chrome/browser/browser.scons

Issue 15051: Convert from using env['PLATFORM'] directly to using the more flexible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/SConscript ('k') | chrome/browser/debugger/debugger.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser.scons
===================================================================
--- chrome/browser/browser.scons (revision 7247)
+++ chrome/browser/browser.scons (working copy)
@@ -30,7 +30,7 @@
],
)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.Prepend(
CPPPATH = [
'$CHROME_DIR/tools/build/win',
@@ -39,7 +39,7 @@
input_files = []
-if env['PLATFORM'] in ('posix', 'win32'):
+if not env.Bit('mac'):
# TODO: Port to Mac.
input_files.extend([
'autocomplete/keyword_provider.cc',
@@ -117,7 +117,7 @@
'webdata/web_database.cc',
])
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# TODO: Port these.
input_files.extend([
'autofill_manager.cc',
@@ -300,11 +300,11 @@
'web_contents_view_win.cc',
])
-if env['PLATFORM'] in ('darwin', 'posix'):
+if env.Bit('posix'):
input_files.extend([
'importer/firefox_profile_lock_posix.cc',
])
-if env['PLATFORM'] in ('posix', 'win32'):
+if not env.Bit('mac'):
# TODO: This should work for all platforms.
env.ChromeStaticLibrary('browser', input_files)
« no previous file with comments | « chrome/SConscript ('k') | chrome/browser/debugger/debugger.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698