Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2451)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/SConscript.v8

Issue 15051: Convert from using env['PLATFORM'] directly to using the more flexible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « breakpad/SConscript ('k') | build/debug.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/SConscript.v8
===================================================================
--- build/SConscript.v8 (revision 7247)
+++ build/SConscript.v8 (working copy)
@@ -56,7 +56,7 @@
'$V8_MODE_DIR/snapshot${OBJSUFFIX}',
]
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
v8_scons_targets_off.extend([
env.File('$V8_DIR/vc80.pdb')
])
@@ -79,7 +79,7 @@
env.Install('$V8_DIR', '$V8_MODE_DIR/snapshot-empty${OBJSUFFIX}')
# To satisfy tests expecting the following .exe name.
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# TODO(evanm): this may be necessary on other platforms(?)
i = env.InstallAs('$TARGET_ROOT/v8_shell_sample${PROGSUFFIX}', v8[0])
« no previous file with comments | « breakpad/SConscript ('k') | build/debug.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698