Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: third_party/libxml/libxml.scons

Issue 15051: Convert from using env['PLATFORM'] directly to using the more flexible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libpng/libpng.scons ('k') | third_party/libxslt/libxslt.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libxml/libxml.scons
===================================================================
--- third_party/libxml/libxml.scons (revision 7247)
+++ third_party/libxml/libxml.scons (working copy)
@@ -49,14 +49,14 @@
],
)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.Append(
CCFLAGS = [
'/TC',
'/wd4800',
],
)
-elif env['PLATFORM'] == 'posix':
+elif env.Bit('linux'):
env.Append(
CPPDEFINES = [
'_REENTRANT',
@@ -116,7 +116,7 @@
env.ChromeStaticLibrary('libxml', input_files)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
config_files = [
# The configure.js script must be first in this list; the
# env.Command() call below executes the first list element.
@@ -146,7 +146,7 @@
copied_files,
'cd ${SOURCE.dir} && $CSCRIPT ${SOURCE.file} $CONFIG_OPTIONS',
CONFIG_OPTIONS='compiler=msvc iconv=no icu=yes')
-elif env['PLATFORM'] == 'posix':
+elif env.Bit('linux'):
config_files = [
'config.h',
'include/libxml/xmlversion.h',
« no previous file with comments | « third_party/libpng/libpng.scons ('k') | third_party/libxslt/libxslt.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698