Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: net/net_unittests.scons

Issue 15051: Convert from using env['PLATFORM'] directly to using the more flexible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/net_perftests.scons ('k') | net/stress_cache.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/net_unittests.scons
===================================================================
--- net/net_unittests.scons (revision 7247)
+++ net/net_unittests.scons (working copy)
@@ -22,12 +22,12 @@
'$ZLIB_DIR/using_zlib.scons',
])
-if env['PLATFORM'] in ('posix', 'darwin'):
+if env.Bit('posix'):
env.SConscript([
'$LIBEVENT_DIR/using_libevent.scons',
], {'env':env})
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.Prepend(
CCFLAGS = [
'/WX',
@@ -85,14 +85,14 @@
'url_request/url_request_unittest.cc',
]
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
input_files.extend([
'base/wininet_util_unittest.cc',
'http/http_transaction_winhttp_unittest.cc',
'http/winhttp_request_throttle_unittest.cc',
])
-if env['PLATFORM'] == 'posix':
+if env.Bit('linux'):
# TODO(port):
to_be_ported_files = [
'base/x509_certificate_unittest.cc',
@@ -101,7 +101,7 @@
]
input_files = list(set(input_files) - set(to_be_ported_files))
-if env['PLATFORM'] == 'darwin':
+if env.Bit('mac'):
input_files.extend([
'../base/platform_test_mac$OBJSUFFIX',
])
« no previous file with comments | « net/net_perftests.scons ('k') | net/stress_cache.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698