Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: webkit/SConscript.port

Issue 15051: Convert from using env['PLATFORM'] directly to using the more flexible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/SConscript.javascriptcore_pcre ('k') | webkit/build/JavaScriptCore/SConscript » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/SConscript.port
===================================================================
--- webkit/SConscript.port (revision 7247)
+++ webkit/SConscript.port (working copy)
@@ -6,7 +6,7 @@
env = env.Clone()
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.Prepend(
CCFLAGS = [
'/TP',
@@ -17,7 +17,7 @@
'/wd4521',
'/wd4800',
],)
-elif env['PLATFORM'] == 'posix':
+elif env.Bit('linux'):
env.Append(
# For the image readers and decoders:
CXXFLAGS = ["-Wno-sign-compare"],
@@ -110,7 +110,7 @@
'$PORT_DIR/plugins/chromium/PluginDataChromium.cpp',
]
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# Windows specific implementations.
input_files.extend([
'$PORT_DIR/platform/chromium/FileSystemChromiumWin.cpp',
@@ -131,7 +131,7 @@
'$PORT_DIR/rendering/RenderThemeWin.cpp',
])
-if env['PLATFORM'] == 'posix':
+if env.Bit('linux'):
# Linux specific implementations.
input_files.extend([
'$PORT_DIR/platform/chromium/FileSystemChromiumLinux.cpp',
@@ -157,7 +157,7 @@
]
input_files = list(set(input_files) - set(to_be_ported_files))
-if env['PLATFORM'] == 'darwin':
+if env.Bit('mac'):
# Mac specific implementations.
input_files.extend([
'$PORT_DIR/bridge/mac/FrameMac.mm',
@@ -167,6 +167,8 @@
'$PORT_DIR/platform/PluginStubsMac.cpp',
'$PORT_DIR/platform/mac/DragDataMac.mm',
'$PORT_DIR/platform/graphics/mac/FontCacheMacPending.cpp',
+ '$PORT_DIR/platform/graphics/skia/public/PlatformCanvasMac.cpp',
+ '$PORT_DIR/platform/graphics/skia/public/PlatformDeviceMac.cpp',
'$PORT_DIR/rendering/RenderThemeMac.mm',
])
« no previous file with comments | « webkit/SConscript.javascriptcore_pcre ('k') | webkit/build/JavaScriptCore/SConscript » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698