Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1618)

Unified Diff: webkit/tools/test_shell/SConscript

Issue 15051: Convert from using env['PLATFORM'] directly to using the more flexible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/tools/npapi_layout_test_plugin/SConscript ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/SConscript
===================================================================
--- webkit/tools/test_shell/SConscript (revision 7247)
+++ webkit/tools/test_shell/SConscript (working copy)
@@ -13,7 +13,7 @@
'$CHROME_SRC_DIR/build/using_v8.scons',
], {'env':env})
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env_res.Append(
CPPPATH = [
'.',
@@ -58,7 +58,7 @@
],
)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# TODO(port): put portable libs in above declaration.
env.Append(
LIBS = [
@@ -67,7 +67,7 @@
]
)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.Append(
LIBS = [
'comctl32.lib',
@@ -90,14 +90,14 @@
'/nxcompat',
],
)
-elif env['PLATFORM'] in ('posix', 'darwin'):
+elif env.Bit('posix'):
env.Append(
LIBS = [
'event',
]
)
-if env['PLATFORM'] == 'darwin':
+if env.Bit('mac'):
env.Append(
CPPPATH = [
'$THIRD_PARTY_DIR/WebKit/WebKit/mac/WebCoreSupport',
@@ -115,7 +115,7 @@
'test_webview_delegate.cc',
'text_input_controller.cc',
]
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# TODO(port): Consider porting drag_delegate.cc and drop_delecate.cc.
input_files.extend([
'drag_delegate.cc',
@@ -125,7 +125,7 @@
'webview_host_win.cc',
'webwidget_host_win.cc',
])
-elif env['PLATFORM'] == 'posix':
+elif env.Bit('linux'):
input_files.extend([
'webview_host_gtk.cc',
'webwidget_host_gtk.cc',
@@ -140,7 +140,7 @@
'test_shell_main.cc',
]
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# TODO(port): figure out what to do with resources.
resources = [
env_res.RES('resources/test_shell.rc'),
@@ -157,7 +157,7 @@
i = env.Install('$TARGET_ROOT', test_shell)
env.Alias('webkit', i)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.Depends(test_shell, '$V8_DIR/vc80.pdb')
test_files = [
@@ -189,7 +189,7 @@
'$V8_DIR/snapshot-empty$OBJSUFFIX',
]
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# TODO(port): put portable files in above test_files declaration.
test_files.extend([
'plugin_tests.cc',
« no previous file with comments | « webkit/tools/npapi_layout_test_plugin/SConscript ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698