Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 15023: Focus the textfield when doing a JS prompt (Closed)

Created:
12 years ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make sure the text field is focused when doing a JavaScript prompt (which shows an alert box with a text field in it). BUG=5333 TEST=Load a page that does a prompt("Hello", "World"). It should open an alert box with a text field with the contents 'World'. The text should be selected and the text field should have focus. Make sure alert() and confirm() still have the OK button focused when used. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/jsmessage_box_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/jsmessage_box_handler.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
12 years ago (2008-12-18 01:08:40 UTC) #1
sky
12 years ago (2008-12-18 01:19:18 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698